Added Rich Text to SimpleTextArea!!!! by abb2k · Pull Request #1654 · geode-sdk/geode

abb2k · 2026-01-28T11:44:56Z

HIII :D:D:DD

ive wanted this for a while now so i decided to make it myself :D you can now add rich text keys into a SimpleTextArea! :D

you can do so by using registerRichTextKey on your SimpleTextArea to add a key and tell it

what the main key string is
how will it use the given value and convert it to something you can use later for whatever, and the agility to tell if the key is invalid if you want
what will the key do to a CCFontSprite
what text will be inserted into the keys place after its replaced!

i think this is really cool and i hope u like what i made :D
this might not be the best implementation but u can polish it if you want ofc !!!! i tried my best :D (if you think i did anything wrong or bad i would be happy if you told me i wanna learn!! :D)

abb2k · 2026-01-28T11:45:46Z

(also i didnt try this on any platform other than windows so idk if this works on others but i think it should be fine :))

xblazegmd · 2026-01-28T16:36:10Z

Also, imo it would be convenient if there was a separate type of TextArea specifically for rich text, kinda like MDTextArea which is a text area with Markdown support.

Especially since now the SimpleTextArea isn’t simple anymore lol.

abb2k · 2026-01-28T17:03:19Z

alrighty i committed changes yay :D

xblazegmd · 2026-01-28T17:33:00Z

+             * @param applyToSprite Function to apply the parsed value to a font sprite (optional)
+             * @param stringAddition Function to add a new string at the point where the key is (optional)
+            */
+            RichTextKey(std::string key, geode::Function<Result<T>(const std::string& value)> validCheck, geode::Function<void(const T& value, cocos2d::CCFontSprite* sprite)> applyToSprite = NULL, geode::Function<std::string(const T& value)> stringAddition = NULL)


Maybe this constructor could get cleaned up a bit?

RichTextKey( std::string key, geode::Function<Result<T>(const std::string& value)> validCheck, geode::Function<void(const T& value, cocos2d::CCFontSprite* sprite)> applyToSprite = NULL, geode::Function<std::string(const T& value)> stringAddition = NULL )

And also, idk how to feel about applyToSprite and stringAddition both having NULL as a default value.

I would have personally defined it something like:

RichTextKey( std::string key, geode::Function<Result<T>(const std::string& value)> validCheck, ) : m_key(std::move(key)), m_validCheck(std::move(validCheck)) {} RichTextKey( std::string key, geode::Function<Result<T>(const std::string& value)> validCheck, geode::Function<void(const T& value, cocos2d::CCFontSprite* sprite)> applyToSprite, ) : m_key(std::move(key), m_validCheck(std::move(validCheck)), m_applyToSprite(std::move(applyToSprite)) {} RichTextKey( std::string key, geode::Function<Result<T>(const std::string& value)> validCheck, geode::Function<void(const T& value, cocos2d::CCFontSprite* sprite)> applyToSprite, geode::Function<std::string(const T& value)> stringAddition ) : m_key(std::move(key), m_validCheck(std::move(validCheck)), m_applyToSprite(std::move(applyToSprite)), m_stringAddition(std::move(stringAddition)) {}

Alright :D thats cool i wasent sure of what a good way of writing that was :) ill improve !

xblazegmd · 2026-01-28T17:38:30Z

I still think it would be better to have a separate sorta RichTextArea with rich text formatting instead of implementing it directly into SimpleTextArea since a: it's cleaner, and b: as I said before, with rich text formatting, SimpleTextArea stops being simple lol.

Final thing I'll say is to make sure the code fits into the code styling guidelines and double check CONTRIBUTING.md while on that.

xblazegmd · 2026-01-28T17:41:22Z

Also whenever I have time I can try and test it on macOS

abb2k · 2026-01-28T20:30:36Z

Cool ty for telling me about the guidlines and stuff i didnt know about them (im noob) ill try my best to improve this code with everything in here :D will update later dw :DD

abb2k · 2026-01-28T22:51:47Z

well ive attempted to apply some things said in the styling guidelines :D there might be more that i forgot but i still feel like the way i placed my classes or the classes themselves is messy, i dont know why :(

abb2k · 2026-01-29T13:31:30Z

Also i never thought of SimpleTextArea as a "text area thats simple in implementation" cz it always looked so much more complex then the normal TextArea i though of it like "simple text area makes it simple for me to do whatever i want" unlike actual TextArea lol

altalk23 · 2026-01-30T23:10:23Z

this might be better as smth that subclasses simpletextarea

abb2k · 2026-01-31T19:35:47Z

Oof :( i really dont understand the problem with it being on the simpletextarea i think its just fine but i respect the opinion and will do something whenever i have the time ig

abb2k · 2026-02-02T12:33:39Z

there have been some updates done to SimpleTextArea that i dont really understand and making it a harder time implementing this cz idk how this works lol, whats the Impl thing you use to separate some things in SimpleTextArea? i thought i would inhairate SimpleTextArea and make a RichTextArea and do what i did before over there but i cant because the charIteration is over at the Impl, how should i go about this?

Fleeym · 2026-02-02T13:03:53Z

SimpleTextArea is now pimpl (pointer to implementation), which makes it easier for us to update the class without breaking ABI. You can read up on it pretty easily. You have to also extend SimpleTextArea's Impl struct for RichTextArea.

xblazegmd · 2026-02-02T23:42:19Z

I want to see if I can try changing it to have in mind the pimpl changes.

I also want to see if I can try and add stuff like links for example so it can "compete" better with MDTextLayer although I want to see what @abb2k thinks abt that first.

I don't promise anything, it's just an idea I have. I want to help, but if I can't or don't have the time or if @abb2k prefers to go solo then I wont.

abb2k · 2026-02-03T11:09:20Z

i wanna add the rich text if u wanna add links using that rich text stuff later u can :D:D

abb2k · 2026-02-03T11:33:48Z

help 😭 😭

it says "incomplete type "geode::SimpleTextArea::Impl" is not allowed", i did make class Impl; in SimpleTextArea protected idk what else i should do

Some changes

abb2k · 2026-02-05T19:02:59Z

Im not feeling bad the help is awesome i appreciate it :D what u did helped and fixed the issues alk talked about i think but now for some reason the rich text isnt working :( i didnt have time to test at all but your changes dont seem like they should break anything so idk what happened

abb2k · 2026-02-06T03:24:07Z

alright i fixed rich text it fully works now :D (also i added a wave effect text key and a action for it i hope its ok that i added this i just think this is super duper cool :D:D:D:D)

altalk23 · 2026-02-06T15:07:56Z

+        ~RichTextArea();
+
+        class RichImpl;
+        std::unique_ptr<SimpleTextAreaImpl> createImpl() override;


is this really needed instead of just exposing protected methods to simpletextarea for richtextarea to use

altalk23 · 2026-02-06T15:09:10Z

+            if (keyDown){
+                for (const auto& linkCharacter : wordClicked)
+                {
+                    castedImpl->m_ogColorForLink.insert({linkCharacter, linkCharacter->getColor()});


can you expose a method for this instead

still not resolved

the impl should be opaque

altalk23 · 2026-02-06T15:09:50Z

+        }
+    ));
+
+    castedImpl()->formatRichText();


same for this, ideally impl should be opaque to richtextarea in the first place

altalk23 · 2026-02-06T15:11:15Z

@@ -0,0 +1,190 @@
+#include <Geode/DefaultInclude.hpp>


these can be just moved to simpletextarea as protected functions

altalk23 · 2026-02-06T15:11:31Z

+
+using namespace geode::prelude;
+
+class SimpleTextAreaImpl {


ideally this class should just not exist in the first place

abb2k · 2026-02-14T19:33:33Z

i removed the wave effect cz ig its too much for having in the actual loader but i have 0 clue as to how to make the Impl usage good here :( if anyone else wants to help out it would be awesome :) yeah!

altalk23 · 2026-04-10T22:55:02Z

+namespace geode {
+    using namespace geode::prelude;
+
+    class SimpleTextAreaImpl {


this is NOT what i meant, check out how other classes in geode handle actual impl stuff. impl class should NEVER be exposed in public headers

altalk23 · 2026-04-10T22:55:43Z

+            if (keyDown){
+                for (const auto& linkCharacter : wordClicked)
+                {
+                    castedImpl->m_ogColorForLink.insert({linkCharacter, linkCharacter->getColor()});


still not resolved

altalk23 · 2026-04-10T22:56:00Z

+            if (keyDown){
+                for (const auto& linkCharacter : wordClicked)
+                {
+                    castedImpl->m_ogColorForLink.insert({linkCharacter, linkCharacter->getColor()});


the impl should be opaque

altalk23 · 2026-04-10T22:56:08Z

+        }
+    ));
+
+    castedImpl()->formatRichText();


same here again

…ess that would maybe make it not opaque im unsure tho

…own keys properly

…keys from other classes yay :D

… applying effects on characters

abb2k · 2026-04-13T15:17:39Z

oke this should now be working :D ive made some changes and i hope this is good now :D

altalk23

impl in source yea lgtm, worse case its always changeable without breaking abi

Added rich text!

54dcb05

remove CCObjects and changed to geode::Function

ef54576

xblazegmd suggested changes Jan 28, 2026

View reviewed changes

Comment thread loader/include/Geode/ui/TextArea.hpp Outdated

Comment thread loader/include/Geode/ui/TextArea.hpp Outdated

Comment thread loader/include/Geode/ui/TextArea.hpp Outdated

small naming changes and stuff!

8c6b489

xblazegmd reviewed Jan 28, 2026

View reviewed changes

some styling improvements

5001acc

some more very small changes

2cd0a0f

altalk23 deleted the branch geode-sdk:main January 31, 2026 20:03

altalk23 closed this Jan 31, 2026

altalk23 reopened this Jan 31, 2026

altalk23 deleted the branch geode-sdk:main February 1, 2026 19:22

altalk23 closed this Feb 1, 2026

altalk23 reopened this Feb 1, 2026

altalk23 changed the base branch from v5 to main February 1, 2026 19:26

Merge remote-tracking branch 'upstream/main' into v5

e9f1fa2

xblazegmd and others added 3 commits February 5, 2026 13:00

Fix history

f565c01

Merge remote-tracking branch 'origin/main' into rich-txt-area-fix

e9915b1

Merge pull request #2 from xblazegmd/rich-txt-area-fix

e5a1e46

Some changes

abb2k added 2 commits February 6, 2026 03:39

Merge remote-tracking branch 'upstream/main' into v5

392151c

rich text fixed! added wave effect key!

3ed3f57

altalk23 requested changes Feb 6, 2026

View reviewed changes

abb2k added 2 commits February 14, 2026 21:29

Merge remote-tracking branch 'upstream/main' into v5

1894478

removed wave effect :(

052c7c8

abb2k added 3 commits February 16, 2026 20:13

Merge remote-tracking branch 'upstream/main' into v5

bacd1e8

moved Impl into geode namespace

35ff21e

fixed includes being wrong

192b132

abb2k requested a review from altalk23 February 16, 2026 18:15

altalk23 requested changes Apr 10, 2026

View reviewed changes

abb2k added 4 commits April 11, 2026 17:09

Merge remote-tracking branch 'upstream/main' into v5

6053444

solved first issue i think

80a7283

attempted to remove saving castedImpl as a variable as from what i gu…

b4a87e4

…ess that would maybe make it not opaque im unsure tho

split link click functionality into a separate function

e65ea73

abb2k requested a review from altalk23 April 11, 2026 16:00

abb2k added 6 commits April 11, 2026 22:53

fixed RichTextArea not getting itself (oops)

4474348

added method for getting the raw text with the rich keys

94c6712

made 'registerRichTextKey' not template so that others can add their …

6e4459d

…own keys properly

moved a small amount of generic functions so i can actually register …

a525ebb

…keys from other classes yay :D

added a way for people to use local index relative to key origin when…

9541593

… applying effects on characters

fix for link buttons crash and color

66d61a2

altalk23 approved these changes Apr 16, 2026

View reviewed changes

altalk23 merged commit a2e5525 into geode-sdk:main Apr 16, 2026

Conversation

abb2k commented Jan 28, 2026

Uh oh!

abb2k commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xblazegmd commented Jan 28, 2026

Uh oh!

abb2k commented Jan 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xblazegmd commented Jan 28, 2026

Uh oh!

xblazegmd commented Jan 28, 2026

Uh oh!

abb2k commented Jan 28, 2026

Uh oh!

abb2k commented Jan 28, 2026

Uh oh!

abb2k commented Jan 29, 2026

Uh oh!

altalk23 commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abb2k commented Jan 31, 2026

Uh oh!

abb2k commented Feb 2, 2026

Uh oh!

Fleeym commented Feb 2, 2026

Uh oh!

xblazegmd commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abb2k commented Feb 3, 2026

Uh oh!

abb2k commented Feb 3, 2026

Uh oh!

abb2k commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abb2k commented Feb 6, 2026

Uh oh!

Uh oh!

Uh oh!

altalk23 Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abb2k commented Feb 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abb2k commented Apr 13, 2026

Uh oh!

altalk23 left a comment

Choose a reason for hiding this comment

Uh oh!

altalk23 commented Jan 30, 2026 •

edited

Loading

xblazegmd commented Feb 2, 2026 •

edited

Loading

abb2k commented Feb 5, 2026 •

edited

Loading

altalk23 Feb 6, 2026 •

edited

Loading